[PATCH] mmotm: mm-proc-sys-vm-stat_refresh-to-force-vmstat-update-fix

From: Michal Hocko
Date: Mon May 16 2016 - 10:19:53 EST


Arnd has reported:
In randconfig builds with sysfs, procfs and numa all disabled,
but SMP enabled, we now get a link error in the newly introduced
vmstat_refresh function:

mm/built-in.o: In function `vmstat_refresh':
:(.text+0x15c78): undefined reference to `vmstat_text'

vmstat_refresh is proc_fs specific so there is no reason to define it
when !CONFIG_PROC_FS.

Reported-by: Arnd Bergmann <arnd@xxxxxxxx>
Acked-by: Christoph Lameter <cl@xxxxxxxxx>
Signed-off-by: Michal Hocko <mhocko@xxxxxxxx>
---
mm/vmstat.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/mm/vmstat.c b/mm/vmstat.c
index 57a24e919907..c759b526287b 100644
--- a/mm/vmstat.c
+++ b/mm/vmstat.c
@@ -1370,6 +1370,7 @@ static void refresh_vm_stats(struct work_struct *work)
refresh_cpu_vm_stats(true);
}

+#ifdef CONFIG_PROC_FS
int vmstat_refresh(struct ctl_table *table, int write,
void __user *buffer, size_t *lenp, loff_t *ppos)
{
@@ -1422,6 +1423,7 @@ int vmstat_refresh(struct ctl_table *table, int write,
*lenp = 0;
return 0;
}
+#endif

static void vmstat_update(struct work_struct *w)
{
--
2.8.1

--
Michal Hocko
SUSE Labs