Re: Brightness control irrespective of blink state.

From: Jacek Anaszewski
Date: Mon May 16 2016 - 10:32:18 EST


On 05/16/2016 04:23 PM, Jacek Anaszewski wrote:
On 05/16/2016 03:43 PM, Tony Makkiel wrote:
if (led_cdev->flags & LED_BLINK_SW) .

LED_BLINK_SW flag would have to be cleared in led_stop_software_blink()
and in the first two conditions in the led_timer_function().


Yes, that will do with minimal changes. I tested the following, and
works.

Fine, so could you please submit the patch officially?
Before that, please rebase your code on top of LED tree or linux-next
and change LED_BLINKING_SW to LED_BLINK_SW, to keep the same prefix for
each blinking related definition.

Also please put it before LED_BLINK_ONESHOT.

--
Best regards,
Jacek Anaszewski