Re: [PATCH] Input: Change BTN_TOOL_FINGER flag when hover event trigger

From: Dmitry Torokhov
Date: Mon May 16 2016 - 13:53:50 EST


Hi Kt,

On Mon, May 16, 2016 at 07:27:25PM +0800, ååæ wrote:
>
> Only ABS_DISTANCE is not enough for upper OS to distingiush hover event be
> triggered from object from faraway to and close touchpad surface or from
> object prepare to leave the touchpad surface. Add BTN_TOOL_FINGER flag to
> help it.
>
> object_from_faraway object_inside_hover_area
> object_touch_surface
> BTN_TOUCH 0 0 1
> BTN_TOOL_FINGER 0 1 1
> ABS_DISTANCE 0 1 0
>
> Signed-off by: Duson Lin <dusonlin@xxxxxxxxxx>

I was wondering if we could do without modifying all the drivers that
are using input_mt_report_pointer_emulation(), by figuring out if we
should be emitting BTN_TOOL_FINGER right there:

"If device supports ABS_DISTANCE and does not support ABS_MT_DISTANCE and
ABS_DISTANCE != 0 is reported in current frame and there are no other
contacts then report BTN_TOOL_FINGER."

Thanks.

--
Dmitry