Re: [PATCH] net/hsr: Use setup_timer and mod_timer.

From: David Miller
Date: Mon May 16 2016 - 14:01:14 EST


From: Muhammad Falak R Wani <falakreyaz@xxxxxxxxx>
Date: Sun, 15 May 2016 19:37:44 +0530

> The function setup_timer combines the initialization of a timer with the
> initialization of the timer's function and data fields. The mulitiline
> code for timer initialization is now replaced with function setup_timer.
>
> Also, quoting the mod_timer() function comment:
> -> mod_timer() is a more efficient way to update the expire field of an
> active timer (if the timer is inactive it will be activated).
>
> Use setup_timer() and mod_timer() to setup and arm a timer, making the
> code compact and aid readablity.
>
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@xxxxxxxxx>

Applied.