Re: [PATCH] ftrace/x86: Fix function graph tracer reset path

From: Steven Rostedt
Date: Mon May 16 2016 - 15:24:22 EST


On Mon, 16 May 2016 21:19:18 +0200
Borislav Petkov <bp@xxxxxxx> wrote:

> Btw, arch_static_branch_jump() spells that 5-byte JMP too and not until
> too long ago we had it in static_cpu_has()...

Those are "special" too.

If we can get the compiler to do the Right Thing (TM) then we should
let it.

>
> I guess after spending some time with the kernel, one can't really
> differentiate hacks from proper design anymore. :-P
>

That's because a quality of a kernel is determined by the
maintainability of all its hacks, not lack of them.

-- Steve