Re: [RFC][PATCH] printk: Add option to append kernel version to the dict

From: Sergey Senozhatsky
Date: Tue May 17 2016 - 09:45:34 EST


On (05/16/16 15:02), Calvin Owens wrote:
[..]
> > > @@ -2305,6 +2317,8 @@ skip:
> > > sizeof(ext_text) - ext_len,
> > > log_dict(msg), msg->dict_len,
> > > log_text(msg), msg->text_len);
> > > + ext_len += msg_print_ext_uname(ext_text + ext_len,
> > > + sizeof(ext_text) - ext_len);
> > > }
> >
> > what if there is no place left for init_utsname() after
> > msg_print_ext_header() + msg_print_ext_body()?
>
> It ends up being truncated, like either of the preceeding calls would.

well, I meant once it's truncated your matching doesn't work anymore.

-ss