Re: [PATCH] x86/asm/entry: fix stack return address retrieval in thunk

From: Josh Poimboeuf
Date: Tue May 17 2016 - 13:25:20 EST


On Tue, May 17, 2016 at 12:51:41PM -0400, Steven Rostedt wrote:
> On Tue, 17 May 2016 09:31:12 -0700
> Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> > Considering that we got this wrong in two places, it's clearly too
> > subtle for our little brains as-is.
>
> And did we only get this wrong in two places? That is, do we really
> know how little our brains really are?

I've looked again at all the other users of FRAME_BEGIN, and this
pattern of a callee attempting to access the caller's stack is pretty
rare in x86_64 (which is the main user of the macro). My little brain
is telling me there are no more bugs.

--
Josh