Re: [PATCH] xen: add steal_clock support on x86

From: Boris Ostrovsky
Date: Wed May 18 2016 - 10:47:13 EST


On 05/18/2016 08:15 AM, Juergen Gross wrote:
> }
>
> +void __init xen_time_setup_guest(void)
> +{
> + pv_time_ops.steal_clock = xen_steal_clock;
> +
> + static_key_slow_inc(&paravirt_steal_enabled);
> + /*
> + * We can't set paravirt_steal_rq_enabled as this would require the
> + * capability to read another cpu's runstate info.
> + */
> +}

Won't we be accounting for stolen cycles twice now --- once from
steal_account_process_tick()->steal_clock() and second time from
do_stolen_accounting()?

-boris