[PATCH] udf: Check for IS_ERR in udf_get_pblock_meta25

From: Laura Abbott
Date: Wed May 18 2016 - 13:35:41 EST


udf_find_metadata_inode_efe returns an error pointer, not just
NULL. Check the return with IS_ERR appropriately.

Signed-off-by: Laura Abbott <labbott@xxxxxxxxxxxxxxxxx>
---
Came out of https://bugzilla.redhat.com/show_bug.cgi?id=1301295, I never
heard back from the reporter so I've had this sitting around for a bit and
haven't been able to confirm it fixes the crash. The logic makes sense
for the crash though.
---
fs/udf/partition.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/udf/partition.c b/fs/udf/partition.c
index 5f861ed2..a8ee7fc 100644
--- a/fs/udf/partition.c
+++ b/fs/udf/partition.c
@@ -329,7 +329,7 @@ uint32_t udf_get_pblock_meta25(struct super_block *sb, uint32_t block,
}

inode = mdata->s_mirror_fe;
- if (!inode)
+ if (IS_ERR(inode))
return 0xFFFFFFFF;
retblk = udf_try_read_meta(inode, block, partition, offset);
}
--
2.5.5