RE: new driver for drivers/virt/?
From: Sell, Timothy C
Date: Thu May 19 2016 - 02:29:12 EST
> -----Original Message-----
> From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx]
> Sent: Wednesday, May 18, 2016 6:25 PM
> To: Thomas Gleixner
> Cc: Sell, Timothy C; mingo@xxxxxxxxxx; dave.hansen@xxxxxxxxxxxxxxx;
> timur@xxxxxxxxxxxxx; galak@xxxxxxxxxxxxxxxxxxx; Kershner, David A;
> corbet@xxxxxxx; mingo@xxxxxxxxxx; hpa@xxxxxxxxx; Arfvidson, Erik;
> hofrat@xxxxxxxxx; dzickus@xxxxxxxxxx; Curtin, Alexander Paul;
> janani.rvchndrn@xxxxxxxxx; sudipm.mukherjee@xxxxxxxxx;
> prarit@xxxxxxxxxx; Binder, David Anthony; nhorman@xxxxxxxxxx;
> dan.j.williams@xxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-
> doc@xxxxxxxxxxxxxxx; driverdev-devel@xxxxxxxxxxxxxxxxxxxxxx; *S-Par-
> Maintainer; Jes Sorensen
> Subject: Re: new driver for drivers/virt/?
>
> On Thu, May 19, 2016 at 12:11:46AM +0200, Thomas Gleixner wrote:
> > On Wed, 18 May 2016, Sell, Timothy C wrote:
> > > We have a bus driver currently in drivers/staging/unisys/visorbus/ that
> > > we are trying to get out of staging and into the kernel proper. Since
> > > "visorbus" is a driver to host a virtual bus presented to a Linux guest
> > > in a hypervisor environment (refer to
> > > drivers/staging/unisys/Documentation/overview.txt for more details),
> > > Greg KH and Jes Sorensen have suggested the possibility that
> drivers/virt/
> > > might be a good place for visorbus. But right now, we see that the only
> > > driver under drivers/virt/ is the Freescale hypervisor environment,
> which
> > > made us wonder whether this was really the correct place.
> > >
> > > Would you have any guidance for us?
> > > Our intent is to push our visorbus out of staging immediately following
> > > the current merge window.
> >
> > What's the problem with Gregs and Jes suggestion? I don't see any.
>
> Neither do I, odd that they wanted a third opinion :(
Sorry; I didn't intend to belittle your opinions. Since we want to
push code to drivers/virt/, I figured it would be prudent to get
permission from those folks reported by:
./scripts/get_maintainer.pl -f drivers/virt/
first. That was the intent of my original email, and why I chose
the distribution list I did.
I've never done this before, so I spend quite a lot of time groping
around blindly... ;-(
Tim Sell
>
> > There is bigger fish to fry than the final place of this driver. I had just a
> > peek at the staging code and there is enough stuff which wants to be
> cleaned
> > up before moving anywhere. I don't have time to do a proper review now,
> but
> > here are a few hints upfront:
>
> <snip>
>
> I don't think anyone has given a good review of the code yet, I know
> it's been a long time for me. It's on my todo list, but that's not
> going to happen until way after 4.7-rc1 is out. Thanks for this initial
> list.
>
> greg k-h