Re: [PATCH] amdgpu/uvd: use kmemdup

[Muhammad Falak R Wani]

On Thu, May 19, 2016 at 01:18:10PM +0200, Christian König wrote:
> Am 19.05.2016 um 13:11 schrieb Muhammad Falak R Wani:
> >Use kmemdup when some other buffer is immediately copied into allocated
> >region. It replaces call to allocation followed by memcpy, by a single
> >call to kmemdup.
> >
> >Signed-off-by: Muhammad Falak R Wani <falakreyaz@xxxxxxxxx>
> 
> NAK, actually using memcpy() is wrong in the first place.
> 
> The UVD BO is in VRAM so the pointer is pointing to IO memory here,
> so this should be memcpy_fromio() instead of memcpy().
> 
> Christian.
> 
Should I send V2 with the required changes, and I had a query, 
If memcpy was wrong, did it still work or it just got un-noticed ?