Re: [PATCH v2 00/14] staging: comedi: daqboard2000: checkpatch clean-ups

[Ian Abbott]

On 19/05/16 11:16, Ian Abbott wrote:
> On 19/05/16 11:02, Ian Abbott wrote:
> > On 18/05/16 13:36, Ian Abbott wrote:
> > > Patches 03 and 06 have checkpatch warnings themselves about CamelCase
> > > issues, but they are not "new" issues, and are resolved by the later
> > > patches in the series.
> > >
> > > 01) staging: comedi: daqboard2000: remove commented out code
> > > 02) staging: comedi: daqboard2000: use usual block comment style
> > > 03) staging: comedi: daqboard2000: CHECK: spaces preferred around that
> > >      '*'
> > > 04) staging: comedi: daqboard2000: add blank line after struct
> > >      declaration
> > > 05) staging: comedi: daqboard2000: rename serial EEPROM register macros
> > > 06) staging: comedi: daqboard2000: rename register offset macros
> > > 07) staging: comedi: daqboard2000: rename acquisition control register
> > >      macros
> > > 08) staging: comedi: daqboard2000: rename acq status register macros
> > > 09) staging: comedi: daqboard2000: redo DAC control register macros
> > > 10) staging: comedi: daqboard2000: redo DAC status macros and fix busy
> > > 11) staging: comedi: daqboard2000: rename trigger control register
> > >      macros
> > > 12) staging: comedi: daqboard2000: rename reference DACs register macros
> > > 13) staging: comedi: daqboard2000: rename CamelCase functions
> > > 14) staging: comedi: daqboard2000: prefer usleep_range()
> > >
> > > v2: Incorporate suggestions by H Hartley Sweeten, adding a couple of
> > > comments in patch 01, changing a prefix from `DAQBOARD2000_` to `DB2K_`
> > > in patches 05 onwards, and changing a `udelay(10)` to `usleep_range(10,
> > > 20)` in patch 14.
> > >
> > >   drivers/staging/comedi/drivers/daqboard2000.c | 380
> > > +++++++++++++-------------
> > >   1 file changed, 189 insertions(+), 191 deletions(-)
> >
> > I posted a v3 of patches 06 and 12, following Hartley's comments:
> >
> > [PATCH v3 06/14] staging: comedi: daqboard2000: rename register offset
> > macros
> > [PATCH v3 12/14] staging: comedi: daqboard2000: rename reference DACs
> > register macros
>
> And then I posted a v4 of patch 12, correcting a typo I missed in v3:
>
> [PATCH v4 12/14] staging: comedi: daqboard2000: rename reference DACs
> register macros
>
> So patch 06/14 is at v3, patch 12/14 is at v4, and all the others are
> v2.  If that's too much hassle to deal with, let me know, and I'll
> repost the whole series as v4.  And sorry for the hassle.

Scratch all that, I'm posting a full v4 series.

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx> )=-
-=(                          Web: http://www.mev.co.uk/  )=-