Re: [PATCH v2 0/6] Input: soc_button_array fixes and support of the Surface 3

[Benjamin Tissoires]

On May 17 2016 or thereabouts, Bastien Nocera wrote:
> On Fri, 2016-05-13 at 18:05 +0200, Benjamin Tissoires wrote:
> > Hi,
> > 
> > This is the v2 of the series with 3 extra patches to add support of
> > the buttons
> > found on the Surface 3.
> > 
> > Cheers,
> > Benjamin
> > 
> > 
> > Benjamin Tissoires (6):
> > Â Input - soc_button_array: use gpio_is_valid()
> > Â Input - soc_button_array: bail out earlier if gpiod_count is null
> > Â Input - soc_button_array: make sure one GPIO is not assigned twice
> > Â Input - soc_button_array: allow to specify active_low
> > Â Input - soc_button_array: export part of the internals
> > Â Input - surface3_button_array: Introduce button support for the
> > ÂÂÂÂSurface 3
> 
> Works on my Surface 3, the volume buttons, and the Windows button work
> as expected. Note that the power button does not send out any events on
> my machine, but that might be due to firmware differences.
> 
> My BIOS is listed as version 1.51116.78 released 03/09/2015.
> 
> As there's no errors generated, it would be fine to look at it as a bug
> fix later on (or for me to updated my system).
> 
> Tested-by: Bastien Nocera <hadess@xxxxxxxxxx>

Bastien told me in a different thread that the power button is not
working only after a reboot from Windows. After a cold start, it works
fine. There might be something that needs to be set at the I2C level,
but I think while we don't know much about the I2C protocol there, it
should be safe to still get this upstream.

Cheers,
Benjamin