Re: get_maintainer.pl and MAINTAINERS file

From: Kalle Valo
Date: Fri May 20 2016 - 09:14:33 EST


Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxx> writes:

> Em Thu, 19 May 2016 16:25:45 +0200
> Richard Weinberger <richard.weinberger@xxxxxxxxx> escreveu:
>
>> On Thu, May 19, 2016 at 2:57 PM, Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote:
>> > (Changed the subject from "Re: [PATCH v6 0/3] auxdisplay: Introduce ht16k33 driver")
>> >
>> > Robin van der Gracht <robin@xxxxxxxxxxx> writes:
>> >
>> >>> And 4th, what is with the insane number of people on cc:? Use
>> >>> get_maintainer.pl correctly please, and don't just hit everyone you
>> >>> can possibly think of with a cc: for no good reason.
>> >>
>> >> I did use the get_maintainer script. I solely passed the patch set as
>> >> command line argument.
>> >
>> > I think get_maintainer script should ignore MAINTAINERS file altogether.
>> > After I did drivers/net/wireless reorganisation, and had to make
>> > numerous changes to MAINTAINERS in the process, I have been CCed to all
>> > sorts of patchsets to which I have nothing to do with (this one
>> > included). I suspect get_maintainer.pl is to blame here.
>>
>> Are you sure it is because you are listed as maintainer for specific files?
>> If you are maintain something you have to be CC'ed.

IIRC I have received patches about i2c and graphics stuff and I have no
recollection of ever sending even a single patch to those subsystems,
let alone maintaining them.

>> It is rather because get_maintainer.pl tries to be smart and uses git to
>> find people who have touched a file...
>>
>> I guess instead you want something like:
>> http://permalink.gmane.org/gmane.linux.kernel.commits.head/538561
>
> I guess what Kalle said is that the get_maintainer.pl script should
> disable, by default, "--git-blame" behavior for some specific files that
> everyone touches like /MAINTAINERS, Documentation/kernel-parameters.txt,
> /CREDITS, etc, as random people that touch on those files aren't really
> interested on being c/c to every change there.

Exactly my point, thank you. No need to pollute people's inboxes
unnecessary.

--
Kalle Valo