Re: [RFC 4/8] usb: phy: move TCSR driver into new file

From: Arnd Bergmann
Date: Fri May 20 2016 - 10:15:57 EST


On Friday 20 May 2016 13:44:14 Mark Brown wrote:
> On Fri, May 20, 2016 at 02:24:14PM +0200, Arnd Bergmann wrote:
> > On Thursday 19 May 2016 14:08:43 Andy Gross wrote:
>
> > > I'd rather do something like what we did for the GSBI. It needed to
> > > change some phy related bits in the TCSR as well. We defined the TCSR
> > > as a syscon, with binding documentation under mfd. If we add a syscon
> > > entry and use it if it is present, we can deal with that pretty
> > > easily. The offsets change for each soc, and this would also fix that
> > > issue because we can change offset based on tcsr compat.
>
> > Works for me, but be aware that this will break the server chips,
> > as ACPI has no support for regmap devices.
>
> Just to be clear there's nothing precluding the use of regmap on ACPI
> devices, it's syscon it doesn't have anything for.
>

Yes, that's what I meant.

Arnd