Re: [PATCH v4 0/6] Add alignment check for DAX mount
From: Verma, Vishal L
Date: Fri May 20 2016 - 13:35:10 EST
On Fri, 2016-05-20 at 14:50 +0000, Kani, Toshimitsu wrote:
> On Thu, 2016-05-19 at 18:37 -0500, Eric Sandeen wrote:
> >
> > On 5/10/16 11:23 AM, Toshi Kani wrote:
> > >
> > >
> > > When a partition is not aligned by 4KB, mount -o dax succeeds,
> > Sorry for being late, but -
> >
> > Shouldn't this and all subsequent patch commits refer to
> > PAGE_SIZE, rather than "4kB?"
> Right, the patch commits should refer to PAGE_SIZE to match with the
> code
> changes.ÂÂI am afraid it may be a bit too late to update, though...
>
> Vishal, do you think you can tweak the logs, "4KB" to "PAGE_SIZE"?
>
> Thanks,
> -Toshi
Hi Toshi,
Is it just commit message changes? If so I'm not sure it is worthwhile
to rebase everything for that - i.e. my dax error handling series and
Ross' dax-locking branch would both have to be rebased..
If there are and fixes for code, we can do them as an add-on patch
though.