Re: [PATCH 1/3] netfilter: ipset: use setup_timer() and mod_timer().

From: Jozsef Kadlecsik
Date: Fri May 20 2016 - 16:46:32 EST


On Sat, 14 May 2016, Muhammad Falak R Wani wrote:

> Use setup_timer() and instead of init_timer(), being the preferred way
> of setting up a timer.
>
> Also, quoting the mod_timer() function comment:
> -> mod_timer() is a more efficient way to update the expire field of an
> active timer (if the timer is inactive it will be activated).
>
> Use setup_timer() and mod_timer() to setup and arm a timer, making the
> code compact and easier to read.
>
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@xxxxxxxxx>
> ---
> net/netfilter/ipset/ip_set_bitmap_gen.h | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)

The patch and the other too in the series as well are applied in the ipset
git repository and will be submitted for kernel inclusion. Thanks.

Best regards,
Jozsef
-
E-mail : kadlec@xxxxxxxxxxxxxxxxx, kadlecsik.jozsef@xxxxxxxxxxxxx
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
H-1525 Budapest 114, POB. 49, Hungary