Re: [PATCH v4] platform:x86: Add PMC Driver for Intel Core SOC

From: dbasehore .
Date: Fri May 20 2016 - 20:34:56 EST


On Thu, May 12, 2016 at 6:50 AM, Rajneesh Bhardwaj
<rajneesh.bhardwaj@xxxxxxxxx> wrote:
>
> + * pmc_dev contains info about power management controller device.
> + */
> +struct pmc_dev {
> + u32 base_addr;
> + void __iomem *regmap;
> +#if IS_ENABLED(CONFIG_DEBUG_FS)
> + struct dentry *dbgfs_dir;
> +#endif /* CONFIG_DEBUG_FS */
> + bool has_slp_s0_res;
> +};
> +
> +int intel_pmc_slp_s0_counter_read(u64 *data);


Can this function be split out into another header file? The struct
pmc_dev is internal, but this function is needed as an external
interface.