Re: [PATCH 2/2] ip6_gre: Set flowi6_proto as IPPROTO_GRE in xmit path.

From: 严海双
Date: Fri May 20 2016 - 23:46:51 EST



> On May 21, 2016, at 1:48 AM, David Miller <davem@xxxxxxxxxxxxx> wrote:
>
> From: Haishuang Yan <yanhaishuang@xxxxxxxxxxxxxxxxxxxx>
> Date: Wed, 18 May 2016 18:05:52 +0800
>
>> In gre6 xmit path, we are sending a GRE packet, so set fl6 proto
>> to IPPROTO_GRE properly.
>>
>> Signed-off-by: Haishuang Yan <yanhaishuang@xxxxxxxxxxxxxxxxxxxx>
>
> I think it would be a lot better to initialize the flow protocol field
> properly in ip6gre_tnl_link_config() instead of fixing it up every
> single transmit.
>
>

I agree, I will modify the changes in v2.

Thanks

Haishuang