Re: [PATCH] iio: humidity: hdc100x: correct humidity integration time mask

From: Jonathan Cameron
Date: Sat May 21 2016 - 12:23:36 EST


On 20/05/16 18:44, Matt Ranostay wrote:
> Reviewed-by: Matt Ranostay <mranostay@xxxxxxxxx>
>
> On Fri, May 20, 2016 at 10:06 AM, Alison Schofield <amsfield22@xxxxxxxxx> wrote:
>> Apply the correct mask to enable all available humidity integration
>> times. Currently, the driver defaults to 6500 and all is okay with that.
>> However, if 3850 is selected we get a stuck bit and can't change back
>> to 6500 or select 2500. (Verified with HDC1008)
>>
>> Signed-off-by: Alison Schofield <amsfield22@xxxxxxxxx>
>> Cc: Daniel Baluta <daniel.baluta@xxxxxxxxx>
Applied to the fixes-togreg-post-rc1 branch of iio.git

Thanks,

Jonathan
>> ---
>> drivers/iio/humidity/hdc100x.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/humidity/hdc100x.c b/drivers/iio/humidity/hdc100x.c
>> index fa47676..59aa1cb 100644
>> --- a/drivers/iio/humidity/hdc100x.c
>> +++ b/drivers/iio/humidity/hdc100x.c
>> @@ -55,7 +55,7 @@ static const struct {
>> },
>> { /* IIO_HUMIDITYRELATIVE channel */
>> .shift = 8,
>> - .mask = 2,
>> + .mask = 3,
>
> Yikes that is embarrassing on my part! I guess our validation was only
> in the high resolution mode... good catch!
>
>> },
>> };
>>
>> --
>> 2.1.4
>>