Re: [PATCH 1/4] x86: Save return value from kernel_thread

From: Brian Gerst
Date: Sat May 21 2016 - 22:19:19 EST


On Sat, May 21, 2016 at 9:44 PM, Andy Lutomirski <luto@xxxxxxxxxxxxxx> wrote:
> On Sat, May 21, 2016 at 9:04 AM, Brian Gerst <brgerst@xxxxxxxxx> wrote:
>> Kernel threads should always return zero on success after calling do_execve(). The
>> two existing cases in the kernel (kernel_init() and call_usermodehelper_exec_async())
>> correctly do this. Save a few bytes by storing EAX/RAX instead of an immediate zero.
>> Also fix the 64-bit case which should save the full 64-bits.
>
> Does this have any additional motivation beyond cleanup and fixing an
> inconsequential bug? I.e. does the rest of your series need this?
>
> --Andy

It's just a minor cleanup, not necessary.

--
Brian Gerst