Re: [PATCH 1/1] Staging: rdma: hfi1: rc.c: Fixed coding style issues

From: Dennis Dalessandro
Date: Mon May 23 2016 - 08:39:17 EST


On Mon, May 23, 2016 at 12:06:01PM +0530, Shyam Saini wrote:
Fixed following checkpatch.pl warnings:
Prefer 'unsigned int' to bare use of 'unsigned'
Prefer READ_ONCE(<FOO>) over ACCESS_ONCE(<FOO>)

In general please don't fix two types of issues in the same patch. Also, as to the unsinged -> unsigned int, the linux-rdma maintainer has already said we don't really want all of the code churn for this [1].

I suggest to respin this patch with just the ACCESS_ONCE->READ_ONCE change so that can be reviewed on it's own.

[1] http://marc.info/?l=linux-rdma&m=146308474205407&w=2

-Denny