Re: [PATCH] xen/privcmd: use vma_pages().

From: Boris Ostrovsky
Date: Mon May 23 2016 - 16:27:57 EST


On 05/21/2016 09:09 AM, Muhammad Falak R Wani wrote:
> Replace explicit computation of vma page count by a call to
> vma_pages()
>
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@xxxxxxxxx>
> ---
> drivers/xen/privcmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c
> index df2e6f7..702040f 100644
> --- a/drivers/xen/privcmd.c
> +++ b/drivers/xen/privcmd.c
> @@ -582,7 +582,7 @@ static long privcmd_ioctl(struct file *file,
> static void privcmd_close(struct vm_area_struct *vma)
> {
> struct page **pages = vma->vm_private_data;
> - int numpgs = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
> + int numpgs = vma_pages(vma);
> int numgfns = (vma->vm_end - vma->vm_start) >> XEN_PAGE_SHIFT;
> int rc;
>

Can you combine all three patches into a single one?

Thanks.
-boris