Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended
From: Pali RohÃr
Date: Mon May 23 2016 - 18:22:42 EST
On Tuesday 24 May 2016 00:17:15 Darren Hart wrote:
> On Tue, May 24, 2016 at 12:06:03AM +0200, Pali RohÃr wrote:
> > On Monday 23 May 2016 23:26:55 Darren Hart wrote:
> > > I've queued this. Thanks for your patience.
> >
> > Ok, In that case I would update comments in patch to try it more
> > clear what code is doing.
>
> I thought I had your approval on this one Pali. Apologies if that was
> not the case. Did I miss a change request from you?
>
> If so, please point me at it, and I'll dequeue this one and wait for
> an updated one.
I just wanted to review that code from somebody else and decide if
accept it or not. Because I was not sure if it is OK...
But there was no objection, so patch is OK.
And I pointed that patch could have better comments to describe what it
is doing as at first time I was confused.
So I believe that you can update patch in your queue with new version
which just change comments in source code (without functional changes).
--
Pali RohÃr
pali.rohar@xxxxxxxxx
Attachment:
signature.asc
Description: This is a digitally signed message part.