Re: [PATCH] f2fs: introduce on-disk layout version checking functionality

From: Christoph Hellwig
Date: Tue May 24 2016 - 04:53:50 EST


On Mon, May 23, 2016 at 02:13:57PM -0700, Jaegeuk Kim wrote:
> As Christoph mentioned, how about checking the feature only like this?
>
> 1. if the feature is ON,
> - go 64 bits , when compiled w/ F2FS_MIN_16TB_VOLUME_SUPPORT
> - fail to mount, when compiled w/o F2FS_MIN_16TB_VOLUME_SUPPORT
>
> 2. if the feature is OFF,
> - fail to mount, when compiled w/ F2FS_MIN_16TB_VOLUME_SUPPORT
> - go 32 bits , when compiled w/o F2FS_MIN_16TB_VOLUME_SUPPORT
>
> Thoughts?

That goes on to the next question: why do we even need a config option
for 16TB+ volume support?