Re: [PATCH v5 2/2] skb_array: ring test
From: Michael S. Tsirkin
Date: Tue May 24 2016 - 07:54:45 EST
On Tue, May 24, 2016 at 12:28:09PM +0200, Jesper Dangaard Brouer wrote:
> On Mon, 23 May 2016 23:52:47 +0300
> "Michael S. Tsirkin" <mst@xxxxxxxxxx> wrote:
> > On Mon, May 23, 2016 at 03:09:18PM +0200, Jesper Dangaard Brouer wrote:
> > > On Mon, 23 May 2016 13:43:46 +0300
> > > "Michael S. Tsirkin" <mst@xxxxxxxxxx> wrote:
> > >
> > > > Add ringtest based unit test for skb array.
> > > >
> > > > Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
> > > > ---
> > > > tools/virtio/ringtest/skb_array.c | 167 ++++++++++++++++++++++++++++++++++++++
> > > > tools/virtio/ringtest/Makefile | 4 +-
> > >
> > > Patch didn't apply cleanly to Makefile, as you also seems to have
> > > "virtio_ring_inorder", I manually applied it.
> > >
> > > I chdir to tools/virtio/ringtest/ and I could compile "skb_array",
> > > BUT how do I use it??? (the README is not helpful)
> > >
> > > What is the "output", are there any performance measurement results?
> > First, if it completes successfully this means it completed
> > a ton of cycles without errors. It caches any missing barriers
> > which aren't nops on your system.
> I applied these patches on net-next (at commit 07b75260e) and the
> skb_array test program never terminates. Strangely if I use your git
> tree (on branch vhost) the program does terminate... I didn't spot
> the difference.
Oh, that's my bad. You need
ringtest: pass buf != NULL
just a stub pointer for now.
Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
from my tree.