Re: [PATCH 1/3] iio: st_sensors: Init trigger before irq request

From: Crestez Dan Leonard
Date: Tue May 24 2016 - 08:34:24 EST

On 05/24/2016 02:27 PM, Linus Walleij wrote:
> On Fri, May 13, 2016 at 8:43 PM, Crestez Dan Leonard
> <leonard.crestez@xxxxxxxxx> wrote:
>> This fixes a possible race where an interrupt arrives before complete
>> initialization and crashes because iio_trigger_get_drvdata returns NULL.
>> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
>> Cc: Giuseppe Barba <giuseppe.barba@xxxxxx>
>> Cc: Denis Ciocca <denis.ciocca@xxxxxx>
>> Signed-off-by: Crestez Dan Leonard <leonard.crestez@xxxxxxxxx>
>> ---
>> I ran into this while breaking the driver. But since the interrupt line can be
>> shared the handler should always be able to accept and ignore a call.
> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> However I think my patch fixing the thread issue will collide
> by being close in context to this so it'd be great if you
> could resend it on top of
> "iio: st_sensors: switch to a threaded interrupt"?

I checked my local git tree and this was already on top of v6 of that
patch. I think this issue is much less likely to cause problems without
it. Perhaps it should be incorporated into your patch?

I'll resend if it causes conflicts for Jonathan.