[PATCH 4.2.y-ckt 46/53] net: fix infoleak in llc

From: Kamal Mostafa
Date: Tue May 24 2016 - 14:00:15 EST


4.2.8-ckt11 -stable review patch. If anyone has any objections, please let me know.

---8<------------------------------------------------------------

From: Kangjie Lu <kangjielu@xxxxxxxxx>

[ Upstream commit b8670c09f37bdf2847cc44f36511a53afc6161fd ]

The stack object âinfoâ has a total size of 12 bytes. Its last byte
is padding which is not initialized and leaked via âput_cmsgâ.

Signed-off-by: Kangjie Lu <kjlu@xxxxxxxxxx>
Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
Signed-off-by: Kamal Mostafa <kamal@xxxxxxxxxxxxx>
---
net/llc/af_llc.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/net/llc/af_llc.c b/net/llc/af_llc.c
index 8dab4e5..bb8edb9 100644
--- a/net/llc/af_llc.c
+++ b/net/llc/af_llc.c
@@ -626,6 +626,7 @@ static void llc_cmsg_rcv(struct msghdr *msg, struct sk_buff *skb)
if (llc->cmsg_flags & LLC_CMSG_PKTINFO) {
struct llc_pktinfo info;

+ memset(&info, 0, sizeof(info));
info.lpi_ifindex = llc_sk(skb->sk)->dev->ifindex;
llc_pdu_decode_dsap(skb, &info.lpi_sap);
llc_pdu_decode_da(skb, info.lpi_mac);
--
2.7.4