Re: [PATCH] MIPS: Add missing FROZEN hotplug notifier transitions

[David Daney]

On 05/24/2016 06:08 AM, Anna-Maria Gleixner wrote:
> The corresponding FROZEN hotplug notifier transitions used on
> suspend/resume are ignored. Therefore the switch case action argument
> is masked with the frozen hotplug notifier transition mask.
>
> Cc: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
> Cc: linux-mips@xxxxxxxxxxxxxx
> Signed-off-by: Anna-Maria Gleixner <anna-maria@xxxxxxxxxxxxx>

This seems sane, and I don't object, but can you tell us how this was 
tested?

Thanks,
David Daney


> ---
>   arch/mips/cavium-octeon/smp.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/arch/mips/cavium-octeon/smp.c
> +++ b/arch/mips/cavium-octeon/smp.c
> @@ -384,7 +384,7 @@ static int octeon_cpu_callback(struct no
>   {
>   	unsigned int cpu = (unsigned long)hcpu;
>
> -	switch (action) {
> +	switch (action & ~CPU_TASKS_FROZEN) {
>   	case CPU_UP_PREPARE:
>   		octeon_update_boot_vector(cpu);
>   		break;