Re: [PATCH v5] platform:x86: Add PMC Driver for Intel Core SoC

[Andy Shevchenko]

On Tue, May 24, 2016 at 9:54 PM, Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Tue, May 24, 2016 at 5:25 PM, Rajneesh Bhardwaj
> <rajneesh.bhardwaj@xxxxxxxxx> wrote:

>> +static int pmc_core_dev_state_show(struct seq_file *s, void *unused)
>> +{
>> +       struct pmc_dev *pmcdev = s->private;
>> +       u32 counter_val;
>> +
>> +       counter_val = pmc_core_reg_read(pmcdev,
>> +                                       SPT_PMC_SLP_S0_RES_COUNTER_OFFSET);
>> +       seq_printf(s, "%u\n", pmc_core_adjust_slp_s0_step(counter_val));
>> +
>> +       return 0;
>> +}
>> +
>> +static int pmc_core_dev_state_open(struct inode *inode, struct file *file)
>> +{
>> +       return single_open(file, pmc_core_dev_state_show, inode->i_private);
>> +}
>> +
>> +static const struct file_operations pmc_core_dev_state_ops = {
>> +       .open           = pmc_core_dev_state_open,
>> +       .read           = seq_read,
>> +       .llseek         = seq_lseek,
>> +       .release        = single_release,
>> +};
>
> I suppose DEFINE_SIMPLE_ATTRIBUTE might reduce amount of LOC.

Correction:
DEFINE_DEBUGFS_ATTRIBUTE()

-- 
With Best Regards,
Andy Shevchenko