Re: ARM: dts: exynos: Add MFC memory banks for Peach boards

From: Javier Martinez Canillas
Date: Wed May 25 2016 - 11:02:31 EST

Hello Pankaj,

On 05/25/2016 04:33 AM, pankaj.dubey wrote:
> Hi Javier,
> On Friday 29 April 2016 12:51 AM, Javier Martinez Canillas wrote:
>> The MFC nodes with the memory regions reserved for memory allocations
>> are missing in the Exynos5420 Peach Pit and Exynos5800 Peach Pi DTS.
>> This causes the s5p-mfc driver probe to fail with the following error:
>> [ 4.140647] s5p_mfc_alloc_memdevs:1072: Failed to declare coherent memory for MFC device
>> [ 4.216163] s5p-mfc: probe of 11000000.codec failed with error -12
>> Add the missing nodes so the driver probes and the {en,de}coder video
>> nodes are registered correctly:
>> [ 4.096277] s5p-mfc 11000000.codec: decoder registered as /dev/video4
>> [ 4.102282] s5p-mfc 11000000.codec: encoder registered as /dev/video5
>> Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
> Just noticed that, current krzk/for-next failed to boot on Exynos5880
> based Chromebook device. Git bisect is showing culprit as this patch.

Strange, krzk/for-next boots correctly on my Exynos5800 Peach Pi:

$ git log --pretty=oneline --abbrev-commit HEAD
35e691cf5165 Merge branch 'fixes-v4.7' into for-next

$ uname -r

> When I reverted this patch, its able to boot normally.
> Is there any missing patches that we need to take on krzk/for-next to
> boot on Chromebook.

No that I'm aware of. I wonder why it boots for me but fails for
you. Can you please share your complete boot log to see if there
are any hints there?

> Thanks,
> Pankaj Dubey

Best regards,
Javier Martinez Canillas
Open Source Group
Samsung Research America