Re: [PATCH] f2fs: introduce on-disk layout version checking functionality

From: Viacheslav Dubeyko
Date: Wed May 25 2016 - 13:46:31 EST

On Wed, 2016-05-25 at 10:12 -0700, Jaegeuk Kim wrote:

> >
> > So, my logic is simple. We are trying to modify the on-disk layout. As a
> > result, we need to check the on-disk layout version, from my viewpoint.
> > And this modification is not "feature" itself but simple bug fix. And I
> > believe that "major_ver", "minor_ver" in F2FS superblock is the on-disk
> > layout version.
> Hmm, the versions are to indicate f2fs-tools, not on-disk layout something.
> They are simply growing as whatever reasons such as bug fixes, new features,
> and so on to provide debugging information.

OK. If you need to know the version of f2fs-tools then you will try to
extract the version from f2fs-tools itself. And it is possible to track
bug fixes and the new features by means of git repository. The every
release of Linus kernel has own version number. So, again, it's easy to
track bug fixes and new features by means of Linux kernel git
repository. Moreover, struct f2fs_super_block has "version" and
"init_version" fields. These fields store kernel version again. So, it's
really easy to track kernel version and the rest stuff. It's really
crappy way to duplicate information in superblock and to store
f2fs-tools version in the superblock. The really important information
is the on-disk layout version. And f2fs-tools should follow the on-disk
layout version namely.

What do you think?

Vyacheslav Dubeyko.