Re: [PATCH 1/7] zram: rename zstrm find-release functions
From: Sergey Senozhatsky
Date: Wed May 25 2016 - 21:07:48 EST
On (05/26/16 09:44), Minchan Kim wrote:
> On Wed, May 25, 2016 at 11:30:00PM +0900, Sergey Senozhatsky wrote:
> > We don't perform any zstream idle list lookup anymore, so
> > zcomp_strm_find()/zcomp_strm_release() names are not
> > representative.
> >
> > Rename to zcomp_stream_get()/zcomp_stream_put().
>
> Actually, I wanted it when we applied percpu but didn't say to you because
>
> 1. It's preference of author.
>
> Frankly speaking, I prefer get to find but you might think different
> with me so I want to respect patch author's right if it's not huge pain
> to me. :)
> Now I realized you were on same page.
>
> 2. We might roll back to stream list.
>
> In that case, find is proper word again but it's too trivial.
> So, I want to merge this patch regardless of this patchset. :)
>
> >
> > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>
> > Cc: Minchan Kim <minchan@xxxxxxxxxx>
> Acked-by: Minchan Kim <minchan@xxxxxxxxxx>
thanks.
-ss