Re: [PATCH 2/2] staging: dgnc: remove redundant null check in
From: DaeSeok Youn
Date: Thu May 26 2016 - 00:59:52 EST
2016-05-26 7:00 GMT+09:00 Luis de Bethencourt <luisbg@xxxxxxxxxxxxxxx>:
> On 20/05/16 10:51, Daeseok Youn wrote:
>> the "brd" was already checked for NULL before calling dgnc_do_remap().
>> Signed-off-by: Daeseok Youn <daeseok.youn@xxxxxxxxx>
>> drivers/staging/dgnc/dgnc_driver.c | 3 ---
>> 1 file changed, 3 deletions(-)
>> diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c
>> index 22257d2..1882ef5 100644
>> --- a/drivers/staging/dgnc/dgnc_driver.c
>> +++ b/drivers/staging/dgnc/dgnc_driver.c
>> @@ -599,9 +599,6 @@ static int dgnc_finalize_board_init(struct dgnc_board *brd)
>> static void dgnc_do_remap(struct dgnc_board *brd)
>> - if (!brd || brd->magic != DGNC_BOARD_MAGIC)
>> - return;
>> brd->re_map_membase = ioremap(brd->membase, 0x1000);
> Same comment as the 1/2 patch.
I sent an e-mail from the 1/2 patch. it has same reason for this patch.
dgnc_do_remap() function is called twice only in dgnc_found_board() function.
and also DNGC_BOARD_MAGIC was assigned into "brd->magic".
So I think it doesn't need to check about DGNC_BOARD_MAGIC.
> Do you want to keep the brd->magic != DGNC_BOARD_MAGIC check?