Re: [Xen-devel] [PATCH] xen: remove incorrect forward declaration
From: David Vrabel
Date: Thu May 26 2016 - 06:32:48 EST
On 11/05/16 14:07, Arnd Bergmann wrote:
> A bugfix patch for the xen balloon driver introduced a forward
> declaration for a static function that is conditionally compiled,
> causing a warning if only the declaration but not the definition
> are there:
> drivers/xen/balloon.c:154:13: error: 'release_memory_resource' declared 'static' but never defined [-Werror=unused-function]
> static void release_memory_resource(struct resource *resource);
> This removes the declaration again and instead moves the function
> definition to the right place, before its first caller and inside
> of the #ifdef protecting both.
I've applied the equivalent patch from Ross, instead.
> The patch that introduced the warning is marked for stable
> backports, so if that gets applied to 4.4, so should this one.
Fixes for compiler warnings are not sufficiently important to be
backported to stable.