Re: [PATCH v3 10/12] spi: add driver for J-Core SPI controller
From: Rich Felker
Date: Thu May 26 2016 - 21:16:41 EST
On Wed, May 25, 2016 at 11:17:08AM +0100, Mark Brown wrote:
> On Wed, May 25, 2016 at 05:43:03AM +0000, Rich Felker wrote:
> > changes based on ml discussion of the v2 patch. The chipselect change
> > has not been made yet, except for rewriting the current logic to be
> > more clear. If the decision is that it's needed, I can do it easily,
> > but it needs testing still.
> You need to fix that, it's not good to just decide to ignore review
> comments. It is astonishing that you are doing this while expecting to
> bypass the normal process for merging things. I'm not going to look at
> this version, please ensure you have addressed all the feedback from the
> previous review before any new version you submit.
I've made and tested a change that looks like what you want, with the
hw->csReg's chipselect bits set initially high in the probe function,
and only the requested bit being modified by the chipselect function.
Would you prefer I continue to submit this driver with new versions of
the patch series, or separate it out for further review on its own?