Re: [PATCH v5 3/5] perf callchain: Add support for cross-platform unwind
From: Jiri Olsa
Date: Fri May 27 2016 - 04:45:00 EST
On Fri, May 27, 2016 at 04:02:59PM +0800, Hekuang wrote:
> > > The only concern is that, if later we support more platforms,
> > > there will be too much files named as 'tools/perf/util/unwind-libunwind*.c'
> > > Is it acceptable or not?
> > >
> > > And I thought all files belongs to specific archs should
> > > go to folder under 'tools/perf/arch/xxx', is that right?
> > hum, I wouldn't worry about that.. but you're right,
> > let's put them under arch
> But only 'tools/perf/arch/$(host platform)' will be built, in our case,
> we should built the unwind-libunwind-$(arch) as long as we have
> the remote libunwind libraries. So, I think there's a conflict in the
> existing build script and not easy to 'put them under arch'. That's why
> I choose a complex way in my previous patch.
we dive into arch dirs via:
libperf-y += $(ARCH)/
that's not changed AFAICS..