Re: [PATCH] arm: tegra124: remove commas from unit addresses

From: Stephen Warren
Date: Fri May 27 2016 - 14:35:29 EST

On 05/27/2016 10:27 AM, Marcel Ziswiler wrote:
Remove commas from unit addresses as suggested by Rob Herring upon me
posting initial Apalis TK1 support:

diff --git a/arch/arm/boot/dts/tegra124-jetson-tk1.dts b/arch/arm/boot/dts/tegra124-jetson-tk1.dts

- gpu@0,57000000 {
+ gpu@57000000 {
* Node left disabled on purpose - the bootloader will enable
* it after having set the VPR up

The last time a similar patch was proposed[1], I pointed out that U-Boot uses the node name to enable the node, so this change will break GPU functionality on this board. U-Boot has since been updated to find the node to enable using compatible value rather than hard-coding the node name, but this doesn't help people with existing bootloader binaries; kernel changes shouldn't force them to upgrade the bootloader. I think the DT node names are part of the ABI and shouldn't be changed. We can fix this for completely new SoCs, but not existing SoCs.

[1] "[PATCH] ARM: tegra: Remove 0, prefix from unit-addresses".