Re: [PATCH v7] ASoC: cs53l30: Add codec driver support for Cirrus CS53L30

[Mark Brown]

On Wed, May 25, 2016 at 12:38:34PM -0700, Nicolin Chen wrote:

A few minor issues but this is mostly OK so I'll apply - please send
followup patches.

> +	SOC_DOUBLE_R_TLV("ADC1 Pre Amp Gain", CS53L30_ADC1A_AFE_CTL,
> +			 CS53L30_ADC1B_AFE_CTL, CS53L30_ADCxy_PREAMP_SHIFT,
> +			 2, 0, pga_preamp_tlv),
> +	SOC_DOUBLE_R_TLV("ADC2 Pre Amp Gain", CS53L30_ADC2A_AFE_CTL,
> +			 CS53L30_ADC2B_AFE_CTL, CS53L30_ADCxy_PREAMP_SHIFT,
> +			 2, 0, pga_preamp_tlv),

Volume controls should end Volume.

> +	regcache_cache_only(cs53l30->regmap, false);
> +	regcache_sync(cs53l30->regmap);

Should really check the return value here.

> +MODULE_AUTHOR("Paul Handrigan, Cirrus Logic Inc, <Paul.Handrigan@xxxxxxxxxx>");

I'd have much preferred to have seen Paul's signoff on the patch.

Attachment: signature.asc
Description: PGP signature