Re: [PATCH 3/4] dt-bindings: Document Renesas R-Car FCP power-domains usage
From: Geert Uytterhoeven
Date: Sat May 28 2016 - 15:04:12 EST
On Fri, May 27, 2016 at 7:19 PM, Kieran Bingham <kieran@xxxxxxxxxxxxxxx> wrote:
> The example misses the power-domains usage, and documentation that the
> property is used by the node.
> Signed-off-by: Kieran Bingham <kieran@xxxxxxxxxxx>
Thanks for your patch!
> Documentation/devicetree/bindings/media/renesas,fcp.txt | 3 +++
> 1 file changed, 3 insertions(+)
> diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt
> index 1c0718b501ef..464bb7ae4b92 100644
> --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt
> +++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt
> @@ -21,6 +21,8 @@ are paired with. These DT bindings currently support the FCPV and FCPF.
> - reg: the register base and size for the device registers
> - clocks: Reference to the functional clock
> + - power-domains : power-domain property defined with a phandle
> + to respective power domain.
I'd write "power domain specifier" instead of "phandle". While SYSC on R-Car
Gen3 uses #power-domain-cells = 0, the FCP module may show up on another
SoC that uses a different value, needing more than just a phandle.
In fact I'm inclined to leave out the power-domains property completely:
it's not a feature of the FCP, but of the SoC the FCP is part of.
power-domains properties may appear in any device node where needed.
> Device node example
> @@ -30,4 +32,5 @@ Device node example
> compatible = "renesas,r8a7795-fcpv", "renesas,fcpv";
> reg = <0 0xfea2f000 0 0x200>;
> clocks = <&cpg CPG_MOD 602>;
> + power-domains = <&sysc R8A7795_PD_A3VP>;
Adding it to the example doesn't hurt, though.
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds