Re: [PATCH 1/1] iio: light: Added CM36672 Proximity Sensor Driver.

[Jonathan Cameron]

On 29/05/16 09:55, Peter Meerwald-Stadler wrote:
> On Sat, 28 May 2016, Kevin Tsai wrote:
> 
>> Added Vishay Capella CM36672 Proximity Sensor IIO driver.  Support both
>> ACPI and Device Tree.
> 
> comments below
>  
>> Signed-off-by: Kevin Tsai <capellamicro@xxxxxxxxx>
>> ---
<snip>
>> +#ifdef CONFIG_ACPI
>> +/**
>> + * cm36672_acpi_get_cpm_info() - Get CPM object from ACPI
>> + * @client:	pointer of struct i2c_client.
>> + * @obj_name:	pointer of ACPI object name.
>> + * @count:	maximum size of return array.
>> + * @vals:	pointer of array for return elements.
>> + *
>> + * Convert ACPI CPM table to array. Special thanks Srinivas Pandruvada's
> 
> thanks for
thanks to (if we are getting picky ;)
> 
>> + * help to implement this routine.
>> + *
>> + * Return: -ENODEV for fail. Otherwise is number of elements.
> 
> Otherwise the number of elements
>