Re: [PATCH v2 1/2] mmc: dw_mmc: remove redundant of set_bit and clear_bit
From: Jaehoon Chung
Date: Sun May 29 2016 - 19:18:34 EST
Hi Shawn,
Applied on my repository.
Thanks!
Best Regards,
Jaehoon Chung
On 05/27/2016 03:36 PM, Shawn Lin wrote:
> dw_mci_get_cd have already dealt with these for
> both of internal card-detect and gpio card-detect.
>
> Signed-off-by: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx>
>
> ---
>
> Changes in v2: None
>
> drivers/mmc/host/dw_mmc.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index 829a6ee..cb30e91 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -2616,10 +2616,7 @@ static int dw_mci_init_slot(struct dw_mci *host, unsigned int id)
> mmc->max_seg_size = mmc->max_req_size;
> }
>
> - if (dw_mci_get_cd(mmc))
> - set_bit(DW_MMC_CARD_PRESENT, &slot->flags);
> - else
> - clear_bit(DW_MMC_CARD_PRESENT, &slot->flags);
> + dw_mci_get_cd(mmc);
>
> ret = mmc_add_host(mmc);
> if (ret)
>