Re: [PATCH] HSI: cmt_speech: use vma_pages().

From: Sebastian Reichel
Date: Mon May 30 2016 - 01:13:29 EST


Hi,

On Sat, May 21, 2016 at 06:49:21PM +0530, Muhammad Falak R Wani wrote:
> Replace explicit computation of vma page count by a call to
> vma_pages()
>
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@xxxxxxxxx>
> ---
> drivers/hsi/clients/cmt_speech.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hsi/clients/cmt_speech.c b/drivers/hsi/clients/cmt_speech.c
> index 95638df..b16cfa4 100644
> --- a/drivers/hsi/clients/cmt_speech.c
> +++ b/drivers/hsi/clients/cmt_speech.c
> @@ -1275,7 +1275,7 @@ static int cs_char_mmap(struct file *file, struct vm_area_struct *vma)
> if (vma->vm_end < vma->vm_start)
> return -EINVAL;
>
> - if (((vma->vm_end - vma->vm_start) >> PAGE_SHIFT) != 1)
> + if (vma_pages(vma) != 1)
> return -EINVAL;
>
> vma->vm_flags |= VM_IO | VM_DONTDUMP | VM_DONTEXPAND;

Thanks, queued for 4.8.

-- Sebastian

Attachment: signature.asc
Description: PGP signature