Re: [PATCH 0/4] pwm: add support for ChromeOS EC PWM
From: Tomeu Vizoso
Date: Mon May 30 2016 - 02:44:58 EST
On 05/28/2016 03:39 AM, Brian Norris wrote:
> This series adds support for the new ChromeOS EC PWM API, so we can control,
> e.g., the backlight when it's attached to the EC. It uses Boris's latest
> "atomic" hooks for the PWM API (i.e., the ->apply() callback), which were
> recently merged.
> It seems nice to have the cros_ec_cmd_xfer_status() helper, which we have
> locally in the ChromeOS kernel, and which has been part of another larger patch
> So I've picked it into this series as well. Obviously, I don't care which one
> is taken, but AFAICT, Tomeu's USB PD series isn't extremely active right now.
that's on hold during the ongoing discussion about type-c userspace API,
because right now the value of that patchset is on how userspace can
decide from what port to charge (if any), and it was badly abusing a
power supply property for that.
> As this touches MFD (sort of), drivers/platform/chrome/, and drivers/pwm/, I'm
> not sure who it should all go through: Lee, Thierry, or Olof?
> Anyway, please review.
> Brian Norris (3):
> mfd: cros_ec: add EC_PWM function definitions
> doc: dt: pwm: add binding for ChromeOS EC PWM
> pwm: add ChromeOS EC PWM driver
> Tomeu Vizoso (1):
> mfd: cros_ec: Add cros_ec_cmd_xfer_status helper
> .../devicetree/bindings/pwm/google,cros-ec-pwm.txt | 25 +++
> drivers/platform/chrome/cros_ec_proto.c | 15 ++
> drivers/pwm/Kconfig | 7 +
> drivers/pwm/Makefile | 1 +
> drivers/pwm/pwm-cros-ec.c | 230 +++++++++++++++++++++
> include/linux/mfd/cros_ec.h | 18 ++
> include/linux/mfd/cros_ec_commands.h | 31 +++
> 7 files changed, 327 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.txt
> create mode 100644 drivers/pwm/pwm-cros-ec.c