Re: [patch v2 net-next 00/13] net: hns: add support of ACPI

[Andy Shevchenko]

On Mon, 2016-05-30 at 10:10 +0800, Kejian Yan wrote:
> This series adds HNS support of acpi. The routine will call some ACPI
> helper functions, like acpi_dev_found() and acpi_evaluate_dsm(), which
> are not included in other cases. In order to make system compile
> successfully in other cases except ACPI, it needs to add relative stub
> functions to linux/acpi.h. And we use device property functions
> instead
> of serial helper functions to suport both DT and ACPI cases. And then
> add the supports of ACPI for HNS.

Looks better. I have only kinda bikeshedding comments in mind, which I
didn't put here, though there is one you perhaps need to address.

Otherwise FWIW:
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

> 
> change log:
> Âv1 -> v2:
> Â1. use acpi_dev_found() instead of acpi_match_device_ids() to check
> if
> it is a acpi node.
> Â2. use is_of_node() instead of IS_ENABLED() to check if it is a DT
> node.
> Â3. split the patch("add support of acpi for hns-mdio") into two
> patches:
> ÂÂÂÂ3.1 Move to use fwnode_handle
> ÂÂÂÂ3.2 Add ACPI
> Â4. add the patch which subject is dsaf misc operation method
> Â5. fix the comments by Andy Shevchenko
> 
> Kejian Yan (13):
> Â ACPI: bus: add stub acpi_dev_found() to linux/acpi.h
> Â ACPI: bus: add stub acpi_evaluate_dsm() to linux/acpi.h
> Â net: hisilicon: cleanup to prepare for other cases
> Â net: hisilicon: add support of acpi for hns-mdio
> Â net: hns: use device_* APIs instead of of_* APIs
> Â net: hns: use platform_get_irq instead of irq_of_parse_and_map
> Â net: hns: enet specify a reference to dsaf by fwnode_handle
> Â net: hns: add uniform interface for phy connection
> Â net: hns: add dsaf misc operation method
> Â net: hns: dsaf adds support of acpi
> Â net: hns: register phy device in each mac initial sequence
> Â net: hns: implement the miscellaneous operation by asl
> Â net: hns: net: hns: enet adds support of acpi
> 
> Âdrivers/net/ethernet/hisilicon/hns/hnae.cÂÂÂÂÂÂÂÂÂÂ|ÂÂ18 +-
> Âdrivers/net/ethernet/hisilicon/hns/hnae.hÂÂÂÂÂÂÂÂÂÂ|ÂÂÂ5 +-
> Âdrivers/net/ethernet/hisilicon/hns/hns_ae_adapt.cÂÂ|ÂÂÂ6 +-
> Âdrivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c |ÂÂÂ6 +-
> Âdrivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.cÂÂ| 247
> +++++++++++++++-----
> Âdrivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.hÂÂ|ÂÂÂ4 +-
> Âdrivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 105 ++++++---
> Âdrivers/net/ethernet/hisilicon/hns/hns_dsaf_main.h |ÂÂ33 ++-
> Âdrivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c | 250
> ++++++++++++++++++---
> Âdrivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.h |ÂÂÂ7 +-
> Âdrivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.cÂÂ|ÂÂ15 +-
> Âdrivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.cÂÂ|ÂÂÂ5 +-
> Â.../net/ethernet/hisilicon/hns/hns_dsaf_xgmac.cÂÂÂÂ|ÂÂ10 +-
> Âdrivers/net/ethernet/hisilicon/hns/hns_enet.cÂÂÂÂÂÂ|ÂÂ90 +++++---
> Âdrivers/net/ethernet/hisilicon/hns/hns_enet.hÂÂÂÂÂÂ|ÂÂÂ2 +-
> Âdrivers/net/ethernet/hisilicon/hns/hns_ethtool.cÂÂÂ|ÂÂÂ2 +-
> Âdrivers/net/ethernet/hisilicon/hns_mdio.cÂÂÂÂÂÂÂÂÂÂ| 147 +++++++-----
> Âinclude/linux/acpi.hÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂ13 ++
> Â18 files changed, 710 insertions(+), 255 deletions(-)
> 

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy