Re: [PATCH v6 10/11] perf callchain: Support x86 target platform

[Jiri Olsa]

On Sat, May 28, 2016 at 11:59:59AM +0000, He Kuang wrote:
> Support x86(32-bit) cross platform callchain unwind.
> 
> Signed-off-by: He Kuang <hekuang@xxxxxxxxxx>
> ---
>  tools/perf/arch/Build                              |  1 +
>  tools/perf/arch/x86/util/unwind-libunwind.c        |  7 ++++---
>  tools/perf/arch/x86/util/unwind-libunwind_x86_32.c | 21 +++++++++++++++++++++
>  tools/perf/util/unwind-libunwind-local.c           |  4 ++++
>  tools/perf/util/unwind-libunwind.c                 | 19 +++++++++++++------
>  tools/perf/util/unwind.h                           | 10 ++++++++++
>  6 files changed, 53 insertions(+), 9 deletions(-)
>  create mode 100644 tools/perf/arch/x86/util/unwind-libunwind_x86_32.c
> 
> diff --git a/tools/perf/arch/Build b/tools/perf/arch/Build
> index 109eb75..3fc4af1 100644
> --- a/tools/perf/arch/Build
> +++ b/tools/perf/arch/Build
> @@ -1,2 +1,3 @@
>  libperf-y += common.o
>  libperf-y += $(ARCH)/
> +libperf-$(CONFIG_LIBUNWIND_X86)      += x86/util/unwind-libunwind_x86_32.o

we have Build file directly in arch/x86/util/

if you do it like this to include generic file easily
we better fix the include then

jirka