Re: [PATCH] staging: iio: fix ad7606_spi regression

[Geert Uytterhoeven]

On Mon, May 30, 2016 at 3:50 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> As pointed out by Geert Uytterhoeven, the patch was incorrect
> and breaks the driver, which was fortunately pointed out by
> this gcc warning:
>
> drivers/staging/iio/adc/ad7606_spi.c: In function âad7606_spi_read_blockâ:
> drivers/staging/iio/adc/ad7606_spi.c:34: warning: âdataâ is used uninitialized in this function
>
> The effect of the patch is that the data is copied into
> a random memory location (from the uninitialized pointer)
> instead of being byteswapped in place.
>
> This adds the initialization for the 'data' variable back
> to restore the original behavior.
>
> Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Cc: Ksenija Stanojevic <ksenija.stanojevic@xxxxxxxxx>
> Fixes: 87787e5ef727 ("Staging: iio: Fix sparse endian warning")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds