Re: [PATCH 00/26] fb/drm: omapdss: Clean up the headers and separate the two stack
From: Tomi Valkeinen
Date: Mon May 30 2016 - 10:26:58 EST
Hi Peter, Tony,
On 30/05/16 14:42, Peter Ujfalusi wrote:
> Hi,
>
> omapfb is deprecated. It will not receive new features, only bug fixes. On the.
> other hand omapdrm is in active development and the fact that both
> implementation (omapfb and omapdrm) is using the same header file
> (video/omapdss.h) makes implementing new features or doing bigger clean ups in
> omapdrm harder and hared as the change should not break omapfb.
>
> To overcome this issue we need to separate the two implementation. This is the
> aim of this series:
> Create platform_data header for omapdss,
> clean up the header usage and dependencies,
> new header file for omapfb stack (video/omapfb_dss.h)
> local omapdss.h header file for omapdrm.
>
> To generate the set I have used:
> git format-patch -C20 --find-copies-harder
Yeah, you need to drop -C20 to get a bit saner "renames" in the patches =).
But otherwise, looks good.
One thing which is not strictly required, but I think should be added,
is cleaning up the omap-panel-data.h from the drm side. There are many
panels including the file, but not using it.
I don't think there's any sane way to split this series into different
subsystems. So I think we should merge this via drm tree.
Tony, can we get acks from you for the mach-omap2 patches? Do you think
there's anything there that could cause bigger conflicts?
Tomi
Attachment:
signature.asc
Description: OpenPGP digital signature