Re: [PATCH 5/5] RFC spi: sun4i: add DMA support

From: Mark Brown
Date: Mon May 30 2016 - 11:04:08 EST

On Mon, May 30, 2016 at 02:11:51PM +0200, Geert Uytterhoeven wrote:
> On Mon, May 30, 2016 at 1:26 PM, Mark Brown <broonie@xxxxxxxxxx> wrote:
> > On Thu, May 26, 2016 at 07:25:25PM -0000, Michal Suchanek wrote:
> >> - fallback to previous behaviour when DMA initialization fails
> >>
> >> + this has the problem that when the driver happens to load before the dma
> >> driver it will not use dma - can be addressed with a module parameter

> > No, you should pay attention to the error you are getting and let probe
> > deferral happen if that's the error you get.

> Unfortunately DMA is an optional feature.

> There's no way to distinguish between -EPROBE_DEFER due to the SPI master
> driver being probed before the DMA engine driver, and -EPROBE_DEFER due to
> support for the DMA engine not having been compiled in.

I really don't think it's worth caring too much about cases where the
DMA driver hasn't been compiled in, it's not like SPI is the only thing
that's going to be using it. I really think it's better to defer the
problem - not getting DMA (or worse, only getting DMA on some boots) is
not great and if people are optimising on that level my feeling is that
they're probably going to be OK with customizing DT to match. Ideally
we would have something a bit nicer than deferred probe but right now
this seems the more helpful option.

Attachment: signature.asc
Description: PGP signature