[RFC][PATCH v3 0/7] perf config: Reimplement perf_config() using perf_config_set__inter()

From: Taeung Song
Date: Mon May 30 2016 - 12:44:21 EST

Everytime perf_config() is called, perf_config() always read config files.
(i.e. user config '~/.perfconfig' and system config '$(sysconfdir)/perfconfig')

But we need to use 'struct perf_config_set config_set' variable
that already contains all config key-value pairs
to avoid this repetitive work in perf_config().

In other words, if new perf_config() is called,
only first time 'config_set' is initialized
collecting all configs from config files and it work with perf_config_set__iter().

If we do, 'config_set' can be reused wherever using perf_config()
and a feature of old perf_config() is the same as new perf_config()
work without the repetitive work that read the config files.

IMHO, I think this patchset is needed because not only the repetitive work
should be avoided but also in near future, it would be smooth to manage perf configs.

Most important patch of this patchset is "[PATCH v3 4/7] perf config: Reimplement
perf_config() using perf_config_set__iter()" and PATCH 1/7 ~ 3/7 are preparation for it.

If you give me any feedback, I'd apprecicated it. :)


- add freeing config set after sub-command work at run_builtin() (Namhyung)
- remove needless code about config set at cmd_config()
- add a patch about a global variable 'config_set'

- split a patch into several patches
- reimplement show_config() using new perf_config()
- modify perf_config_set__delete using global variable 'config_set'
- reset config set when only 'config' sub-commaned work
because of options for config file location

Taeung Song (7):
perf config: Use new perf_config_set__init() to initialize config set
perf config: Add global variable 'config_set'
perf config: Modify perf_config_set__delete() using global variable
perf config: Reimplement perf_config() using perf_config_set__iter()
perf config: Reimplement show_config() using perf_config()
perf config: Remove needless code about config set at cmd_config()
perf config: Reset the config set at only 'config' sub-command

tools/perf/builtin-config.c | 42 ++++--------
tools/perf/perf.c | 1 +
tools/perf/util/cache.h | 1 +
tools/perf/util/config.c | 156 +++++++++++++++++++++++++++++---------------
tools/perf/util/config.h | 2 +-
5 files changed, 118 insertions(+), 84 deletions(-)